Re: [PHP4BETA] Re: [PHP-DEV] Re: [PHP4BETA] CVS update: php4

Sascha Schumann wrote: > > On Wed, Apr 21, 1999 at 09:34:25PM +0300, Zeev Suraski wrote: > > As it broke PHP 3.0.7-dev under Windows, it broke PHP 4.0 as well... > > Well, if it breaks the compilation, why not simply fix it? > > > php_compat.h is only necessary for flock, if I'm not mistaken. > > and inet_ntoa() > > > In that case, please include it only where it's really necessary, and also > > name it appropriately. Right now, including that file from php.h kills > > Win32 compilations. > > Suggestion for a new name? If we have code or header files that are used for OS-specific stuff, I think we should make an "os" subdirectory like Apache has. Stuff like inet_ntoa() is definitely candidate to an "OS compatibility library" based on configure tests. - Stig -- PHP 4 Beta