Re: [PHP4BETA] sprintf weirdness
| From: | Stig Bakken | Date: | Tue, 31 Aug 1999 14:33:10 +0000 |
| Subject: | Re: [PHP4BETA] sprintf weirdness | ||
| References: | 1 | Groups: | php.version4 |
| Request: | Send a blank email to php-version4+get-3906@lists.php.net to get a copy of this message | ||
On Tue, 31 Aug 1999, Thies C. Arntzen wrote:
> hi,
> i think our BROKEN_SPRINTF marco is kinda useless (see Bug id #2033)
>
> i think we should use sprintf in the code and if BROKEN_SPRINTF is set we
> #define sprintf php_sprintf
>
> this define should be in php.h as you'll get no warning if you
> forget to #include "snprintf.h" -> which will end up in something like
> #2033
>
> the other approach would be to always use php_sprintf - but that would be
> "more" typing...
I think we should use the Apache approach (I find myself doing that all
the time :-) and define sprintf to php_sprintf if the OS one is broken.
- Stig