Re: [PHP4BETA] forward/back port of modules....

On Sat, 24 Apr 1999, Zeev Suraski wrote: > On Sat, 24 Apr 1999, Thies C. Arntzen wrote: > > > do we think it makes any sense to have the modules (in my case oci8) to > > compile in both php3 and php4.... > > > > i got oci8 to compile by doing stuff like: > > > > #if PHP_API_VERSION < 19990421 > > #include "internal_functions.h" > > #include "php3_list.h" > > #include "head.h" > > #endif > > > > but now i need to get the array stuff working (an i prefer only to have > > ONE sorce to work on....) - so should i go ahead with "#if PHP_API_VERSION > > < 19990421" stuff??? > > This is my very own personal opinion. > > IMHO, it would be wrong to obscure the code with a lot of precompiler > directives and additional wrapper code to allow a module to be compiled > under both php3 and php4. IMHO #2, trying to maintain two active > development platforms was one of the main reasons PHP 3.1 never took off. > > I'd much rather forget about php3 active development for now, and > concentrate on getting a full php4 beta out the door within a couple of > months. People can handle no new features for a few months. Striking bug > fixes are best off back ported to php3 as well, but that's about it. > Trying to have the same files compile under both php3 and php4 will either > limit us from doing php4 the Right Way (i.e., conduct any changes we > believe are due), or make the code look awful and be completely > unmaintainable. zeev, i do agree in a way - but as i'm still really doing real work on that special part i will try to keep it compatibe for now. i will stop doing that as soon as we got a stabe php4, that i can rely on. but right now it would add another %% to my daily work on php stuff, which is too expensive to me.... so - yes i do agree in the long term - but, for the short term i would leave it up to the module maintainer... tc > > Again, just my humble opinion. > > Zeev > > > -- > PHP 4 Beta > > > -- PHP 4 Beta