Re: [PHP4BETA] Thread safety

At 17:23 24/04/99 +0200, Stig Sæther Bakken wrote: >It doesn't have to be moved from its own directory to php4, but it >should definitely be integrated as far as the distribution is concerned, >when we get that far. Well, that much is obvious - we wouldn't want the user to start hunting for various libraries in order to get PHP 4.0 to compile. Just like libzend would be seamlessly integrated with the php4 release, so should TSRM. However, it should just seem that way - it should be possible to compile it completely separately from PHP, if we ever want to use it anywhere else. >The reason to use php4's config.h is that you are checking symbols like >HAVE_STDARG_H and PTHREADS in TSRM.c. These should be detected by >configure, but I think having a separate configure setup for TSRM is a >bit overkill, so I figured it could use PHP's (that already checks for >that header file, and we would have to add a pthreads check for the >--enable-thread-safety option anyway). I'd go with a separate configure for the reason mentioned above... I don't want any wrong-way references/dependencies in the separate libraries (i.e., libzend, TSRM and SAPI shouldn't include stuff from PHP, TSRM shouldn't include stuff from libzend, etc). The added overhead is worth the modularity... Zeev -- Zeev Suraski <zeev@zend.com> http://www.zend.com/ For a PGP public key, finger bourbon@netvision.net.il -- PHP 4 Beta