Re: [PHP4BETA] Thread safety

Zeev Suraski wrote: > > On Sat, 24 Apr 1999, Stig [iso-8859-1] Sæther Bakken wrote: > > > Okay, how do we integrate TSRM with php4? Right now I have checked it > > out inside the php4 directory (could make a symlink like with libzend as > > well, but all the source gets updated with one "cvs update" this way). > > > > What I'll do for now is to set up automake in the TSRM (why the caps, > > btw?) directory as well and use php4's config.h, and this way make it > > part of php4. > > That's not what I had in mind. TSRM is ultra simple and only need a > couple of definitions in order to know what thread routines to use. > There's no reason to make it a part of libzend or php4, and I don't see > any reason to make it use their config.h's... Or do you think there is? It doesn't have to be moved from its own directory to php4, but it should definitely be integrated as far as the distribution is concerned, when we get that far. The reason to use php4's config.h is that you are checking symbols like HAVE_STDARG_H and PTHREADS in TSRM.c. These should be detected by configure, but I think having a separate configure setup for TSRM is a bit overkill, so I figured it could use PHP's (that already checks for that header file, and we would have to add a pthreads check for the --enable-thread-safety option anyway). - Stig -- PHP 4 Beta