Re: [PHP4BETA] explode(), strpos() not binary safe!
| From: | Sascha Schumann | Date: | Tue, 23 Nov 1999 13:28:01 +0000 |
| Subject: | Re: [PHP4BETA] explode(), strpos() not binary safe! | ||
| References: | 1 | Groups: | php.version4 |
| Request: | Send a blank email to php-version4+get-6741@lists.php.net to get a copy of this message | ||
On Tue, Nov 23, 1999 at 01:50:02PM +0100, Thies C. Arntzen wrote:
> hi,
> i think it's time to make the rest of php4 binary safe.
>
> i think we should borrow the libc routines (strstr etc) from OpenBSD (like
> we did with strlcat & strlcpy) and include our own binary-safe version
> with a different (mem_str, mem_chr) name in php4
We already have binary-safe equivalents of many string
functions. Which do you refer to?
zend_binary_strcmp
zend_binary_strcasecmp
php_memnstr (currently only in ext/standard/string.c)
Note that we also need to audit PHP with regard to
thread-unsafe functions (i.e. strtok, getxxxbyzzz). These
shall be replaced by their *_r equivalents.
--
Regards,
Sascha Schumann
Consultant