Re: [PHP4BETA] explode(), strpos() not binary safe!

On Tue, 23 Nov 1999, Sascha Schumann wrote: > On Tue, Nov 23, 1999 at 01:50:02PM +0100, Thies C. Arntzen wrote: > > hi, > > i think it's time to make the rest of php4 binary safe. > > > > i think we should borrow the libc routines (strstr etc) from OpenBSD (like > > we did with strlcat & strlcpy) and include our own binary-safe version > > with a different (mem_str, mem_chr) name in php4 > > We already have binary-safe equivalents of many string > functions. Which do you refer to? explode(), strpos() as an example. > > zend_binary_strcmp > zend_binary_strcasecmp > php_memnstr (currently only in ext/standard/string.c) > > Note that we also need to audit PHP with regard to > thread-unsafe functions (i.e. strtok, getxxxbyzzz). These > shall be replaced by their *_r equivalents. > > -- > > Regards, > > Sascha Schumann > Consultant > > Thies C. Arntzen "One Big-Mac, Small Fries and a Coke!" Digital Collections Phone +49 40 235350 Fax +49 40 23535180 Hammerbrookstr. 93 20097 Hamburg / Germany