Re: [PHP4BETA] cvs: /php4/ext/standard parsedate.y

At 18:13 06/12/1999 , rubys@us.ibm.com wrote:

I'm troubled by the removal of the code that you indicate is "no longer needed". It was introduced yesterday by Rasmus.

Point being? As it was, it was there purely for compilation cleanliness, not functionality, and it was pretty pointless.

I'm also troubled by the comment on the need to undefine YYSTYPE. If the #define for YYSTYPE were moved from zend_compile.h to zend-parser.y, and the other similar #define in zend-parser.h were simply removed , there is no need for parsedate.y to undefine YYSTYPE.

You're wrong here. You can't 'simply remove' the #define from zend-parser.h; As I said, this file is automatically generated, and the bison standard is to define YYSTYPE to int if it's not already defined.

I'll gladly fix all four files if everybody promises to _stop_undoing_my_changes_ <grin>

There aren't any files left to fix (unless you mean the php.h includes from parsedate.y or reentrancy.h, I don't know about that). There's nothing you can do about the YYSTYPE definition in zend-parser.h, and there's no point in the argument passed to parsedate since it's not really used anywhere - the declaration was added to kill a warning (at least I think so - Rasmus?) Zeev -- Zeev Suraski <zeev@zend.com> http://www.zend.com/