Re: [PHP4BETA] cvs: /php4/ext/standard parsedate.y

Well, there were very good reasons for including zend-parser.h from zend_compile.h when we did that, but it's possible that the circumstances have changed. I'll try to conduct this move and see if it works cleanly, if it does, I'll commit it. It's not a dead horse btw, dependencies wise, especially for those playing with zend-parser.y (hint hint), it's very important. Zeev At 21:35 06/12/1999 , rubys@us.ibm.com wrote:

I realize that I am beating a dead horse, but it is my opinion that including the output of bison in any headers that you expect others to use is quite simply an accident waiting to happen. The patch below was tested on a clean checkout, and permits the workarounds to be removed from parsedate.y. With your permission, I will commit the change. Index: zend-scanner.l =================================================================== RCS file: /repository/libzend/zend-scanner.l,v retrieving revision 1.65 diff -u -r1.65 zend-scanner.l --- zend-scanner.l 1999/12/05 23:32:21 1.65 +++ zend-scanner.l 1999/12/06 19:27:39 @@ -48,6 +48,7 @@ #include "zend_constants.h" #include "zend_variables.h" #include "zend_operators.h" +#include "zend-parser.h" #ifdef ZTS # include <fstream.h> Index: zend_compile.c =================================================================== RCS file: /repository/libzend/zend_compile.c,v retrieving revision 1.84 diff -u -r1.84 zend_compile.c --- zend_compile.c 1999/12/05 16:23:45 1.84 +++ zend_compile.c 1999/12/06 19:27:45 @@ -24,6 +24,7 @@ #include "zend_API.h" #include "zend_variables.h" #include "zend_operators.h" +#include "zend-parser.h" ZEND_API zend_op_array *(*zend_compile_files)(int mark_as_ref CLS_DC, int file_count, ...); Index: zend_compile.h =================================================================== RCS file: /repository/libzend/zend_compile.h,v retrieving revision 1.64 diff -u -r1.64 zend_compile.h --- zend_compile.h 1999/12/06 15:31:06 1.64 +++ zend_compile.h 1999/12/06 19:27:48 @@ -28,7 +28,6 @@ #endif #include "zend_llist.h" -#include "zend-parser.h" #define DEBUG_ZEND 0 Index: zend_highlight.c =================================================================== RCS file: /repository/libzend/zend_highlight.c,v retrieving revision 1.7 diff -u -r1.7 zend_highlight.c

--- zend_highlight.c     1999/07/19 20:02:12  1.7
+++ zend_highlight.c     1999/12/06 19:27:48

@@ -23,6 +23,7 @@ #include "zend_highlight.h" #include "zend_ptr_stack.h" #include "zend_globals.h" +#include "zend-parser.h" #ifndef ZTS extern char *zendtext; Index: zend_indent.c =================================================================== RCS file: /repository/libzend/zend_indent.c,v retrieving revision 1.7 diff -u -r1.7 zend_indent.c --- zend_indent.c 1999/07/19 20:02:12 1.7 +++ zend_indent.c 1999/12/06 19:27:48 @@ -24,6 +24,7 @@ #include "zend.h" #include "zend_compile.h" #include "zend_indent.h" +#include "zend-parser.h" #ifndef ZTS extern char *zendtext;

-- Zeev Suraski <zeev@zend.com> http://www.zend.com/