Re: assert module
| From: | Andrei Zmievski | Date: | Tue, 07 Dec 1999 15:25:46 +0000 |
| Subject: | Re: assert module | ||
| References: | 1 2 | Groups: | php.version4 |
| Request: | Send a blank email to php-version4+get-7608@lists.php.net to get a copy of this message | ||
On Tue, 07 Dec 1999, Thies C . Arntzen wrote:
> On Tue, 7 Dec 1999, Andrei Zmievski wrote:
>
> > >>
> > if ((*assertion)->type == IS_STRING) {
> > zval retval;
> >
> > myeval = (*assertion)->value.str.val;
> > zend_eval_string(myeval, &retval CLS_CC ELS_CC);
> > convert_to_boolean(&retval);
> > val = retval.value.lval;
> > } else {
> > convert_to_boolean_ex(assertion);
> > val = (*assertion)->value.lval;
> > }
> > >>
> >
> > I am not sure I agree with this code. assert() function should only
> > receive a boolean result (or convert something to boolean if it's not).
> > What is the purpose of passing a string in?
> see my previous mail. assert() is *magic*!!
Thies, you're too fast. Leave something for me. :)
-Andrei
* Anything will fit if you push hard enough *