Re: [PHP4BETA] cvs: /php4/ext/standard output.c

On Sat, 15 Jan 2000 rasmus@php.net wrote: > > Index: php4/ext/standard/output.c > > diff -u php4/ext/standard/output.c:1.13 php4/ext/standard/output.c:1.14 > > --- php4/ext/standard/output.c:1.13 Sat Jan 15 09:16:21 2000 > > +++ php4/ext/standard/output.c Sat Jan 15 09:23:18 2000 > > @@ -396,7 +396,7 @@ > > PHP_FUNCTION(ob_implicit_flush) > > { > > zval **zv_flag; > > - int flag = 0; > > + int flag; > > Uh? I don't think you meant to do that, did you? I did, there's no chance flag would get used without being initialized by the runtime code. I usually don't want to initialize variables if their initialization value will never be used, because it implies that it has some sort of a meaning. Before Sascha submitted the initialization patch, I didn't notice that I forgot to add a default: case to the switch, the bails out. His patch made me realize this, and I submitted the correct fix... Zeev -- Zeev Suraski <zeev@zend.com> http://www.zend.com/