Re: svn: /web/php/trunk/include/ header.inc

On Thu, Dec 30, 2010 at 17:53, Stewart Lord <stewey@ambitious.ca> wrote: > > On 2010-12-30, at 8:09 AM, Hannes Magnusson wrote: > >> bjori                                    Thu, 30 Dec 2010 16:09:54 +0000 >> >> Revision: >> http://svn.php.net/viewvc?view=revision&revision=306872 >> >> Log: >> Proper markup > > > Hi Hannes, > > This change causes a couple of (minor) problems in Safari. The search input now has a border > (inside the other border) and a small (x) appears on the right hand side of the box when our > javascript programatically inserts the placeholder text. > > We can certainly remove our JS that manually handles the placeholder text.. Not sure if > it's possible to remove the border via css? I didn't see any changes in chromium, other then the additional 'x' on the right side (which is what I expect from a searchbox anyway). We should probably remove the custom js for the placeholder. As for the border in Safari, that must be possible to remove - we should probably update the reset.css with one of the reset.css for html5.. that would probably do the trick. I feel quite strongly about not emulating random features in all browsers (IE) with js, just do-the-right-thing and let people pick the browser they consider best :] After all, this is a developers website, no need to waste time fixing stuff for a lonely accountant using IE5 from work. -Hannes