Re: svn: /web/php/trunk/include/ header.inc
| From: | Hannes Magnusson | Date: | Thu, 30 Dec 2010 19:04:47 +0000 |
| Subject: | Re: svn: /web/php/trunk/include/ header.inc | ||
| References: | 1 2 3 4 | Groups: | php.webmaster |
| Request: | Send a blank email to php-webmaster+get-10034@lists.php.net to get a copy of this message | ||
On Thu, Dec 30, 2010 at 19:53, Stewart Lord <stewey@ambitious.ca> wrote:
> On 2010-12-30, at 9:06 AM, Hannes Magnusson wrote:
>
>> I didn't see any changes in chromium, other then the additional 'x' on
>> the right side (which is what I expect from a searchbox anyway).
>> We should probably remove the custom js for the placeholder.
>
> The (x) is only expected when the user has entered search terms, but it was showing up when
> only the placeholder text was showing. Fixed that by removing our placeholder js.
>
>> As for the border in Safari, that must be possible to remove - we
>> should probably update the reset.css with one of the reset.css for
>> html5.. that would probably do the trick.
>
> I got rid of the border, took some research. Also, there is padding I can't remove.
> Probably not a big deal, but things don't line up as well as they used to.
>
>> I feel quite strongly about not emulating random features in all
>> browsers (IE) with js, just do-the-right-thing and let people pick the
>> browser they consider best :]
>> After all, this is a developers website, no need to waste time fixing
>> stuff for a lonely accountant using IE5 from work.
>
> Ya, don't get me started on IE. As for this case, well... it worked better before. Not a
> big deal, but I burned an hour getting it back to a slightly worse state.
>
Errr.. Sorry.
I'm not really worried about cross-browser issues yet, but if such a
small (relatively useless) change is causing so much issues, then
revert it :)
-Hannes