Re: svn: /web/php/trunk/ images/shade.png include/header.inc include/layout.inc js/common.js js/jquery.hoverIntent.minified.js styles/structure.css
styles/theme.css

From: Date: Sat, 01 Jan 2011 18:30:05 +0000
Subject: Re: svn: /web/php/trunk/ images/shade.png include/header.inc include/layout.inc js/common.js js/jquery.hoverIntent.minified.js styles/structure.css
styles/theme.css
References: 1 2 3 4  Groups: php.webmaster 
Request: Send a blank email to php-webmaster+get-10150@lists.php.net to get a copy of this message
On 2011-01-01, at 5:12 AM, Hannes Magnusson wrote: > The JS seems unnecessary complicated to me.. > If we move the megadropdown item into its div, and simply show/hide > the js becomes heckofalot simpler, and ignores the doubleclick issue. > > See attached patch. > > -Hannes > <megadropfix.patch.txt> Hi Hannes, If there is a expanded menu, you slide it up and, at the same time, slide the new menu down. This results in an odd effect because we are animating the two menus simultaneously. I think we should slide the new menu down after the slide up animation completes via a callback (as before). Another, less important issue. Previously the sub-menus lived in the list with their parent links which from a semantic html perspective is more correct. By moving the sub-menus around in the dom, we are compromising the structure of our html to make our JS easier. Can't say I care too much about that though. Happy New Year! Stew

« previous php.webmaster (#10150) next »