Re: svn: /web/php/trunk/ images/shade.png include/header.inc include/layout.inc js/common.js js/jquery.hoverIntent.minified.js styles/structure.css
styles/theme.css

From: Date: Sat, 01 Jan 2011 21:31:01 +0000
Subject: Re: svn: /web/php/trunk/ images/shade.png include/header.inc include/layout.inc js/common.js js/jquery.hoverIntent.minified.js styles/structure.css
styles/theme.css
References: 1 2 3 4 5 6 7  Groups: php.webmaster 
Request: Send a blank email to php-webmaster+get-10160@lists.php.net to get a copy of this message
On Sat, Jan 1, 2011 at 21:57, Stewart Lord <stewey@ambitious.ca> wrote: > > On 2011-01-01, at 10:56 AM, Hannes Magnusson wrote: > > On Sat, Jan 1, 2011 at 19:30, Stewart Lord <stewey@ambitious.ca> wrote: > > Another, less important issue. Previously the sub-menus lived in the list > with their parent links which from a semantic html perspective is more > correct. By moving the sub-menus around in the dom, we are compromising the > structure of our html to make our JS easier. Can't say I care too much about > that though. > > > One of the reasons why I didn't commit it :] > > I still haven't thought of a better way to fix this easily. > > -Hannes > > > It does make the code more complicated having to move the sub-menus around > in the dom. Does this fix the issue where clicking a menu would steal the > current menu (e.g. if I go to downloads and click doc, downloads is no > longer 'current')? I thought that might require another class to track > state. It.. kinda, yes, I guess. It doesn't set it on the menu, so the "selected menu" doesn't have any different color then usual. Its no problem adding a "selected" class, but I couldn't think of any proper color to use so I dropped it :P > Let me know if you want me to look at this, otherwise I will continue > playing with designs for the home page. Yes/No is all I expect really :) Your time is best spent on the frontpage imo. Once thats done you can worry about the things I may have made ugly :D -Hannes

« previous php.webmaster (#10160) next »