Re: Questions re prototype.php.net

On Mon, Sep 12, 2011 at 14:58, Nils Luxton <nils.luxton@gmail.com> wrote: > Hi all, > > I had a few questions regarding development for the new php.net site. Sorry > if these have been answered before or if they are noobish, I just want to be > clear about these things before I submit "wrong" patches. > > 1) Is there a PHP version limit? Or are all mirrors required to upgrade to > latest/greatest version in order to mirror the site? Mirrors are required to run 5.2 atleast (see http://php.net/mirroring) > 2) Are there any coding guidelines to follow when creating patches (in terms > of coding style, brackets etc); can this be found online somewhere? We generally use the PEAR coding standard (http://pear.php.net/manual/en/standards.php) > 3) Is there an overall "plan", or any architecture guidelines? From first > glance, the code seems pretty loosely organised (although that could be > because I'm just not used to the way it's organised!), and I noticed that > someone was recently criticised for trying to encourage a separation of > logic/presentation - is there any kind of documentation that governs > decisions like these, or do we just submit patches and await feedback? There aren't any really formal plans for the code no (ouh, except we don't want to use 2mb framework we need to upgrade every other month), only history we try to preserve and respect. Keeping code changes to bare minimum reduces the risk of screwups, and also makes it a lot easier to review. After sending in couple of patches and receiving commit karma you are effectively trusted to commit whatever you want. As for functionality/look&feel, its the members of this list that decide what gets in or tossed out, and we generally want to discuss most things before blindly committing. In the end, its the committer that really has the final say, as who does the job really has the last word on how her code looks. That doesn't mean though that someone doesn't come later on and changes things :) Stuff happens, fights are fought, and battles won. I think most of us are however civilized enough to not getting sucked into petty games, and we are in general quite alright people :) If you screw something up.. You will get notified, and maybe even get a cake thrown at your face - but that just builds character and makes the beer you get in return taste even better \o/ -Hannes