Re: [patch] [beta] Add :hover color to footer and mega-drop-down

On 09/10/2011 01:37 PM, Paul Dragoonis wrote: > On Sat, Sep 10, 2011 at 1:48 AM, Ricky Elrod<php@elrod.me> wrote: >> Not entirely sure of the best way to format patches I send, I suppose this >> will work. >> Anyway this is just a trivial patch that I think makes the beta site look a >> little nicer. (not that >> it doesn't look nice now, it's awesome :D) >> I know this is very simple and whatnot, but more of a first patch to get my >> foot in the door. >> >> Feel free to say it's terrible :) > Hey Ricky, > > You're free to attach the patch file as an attachment to this email. > Can you please attach, or link us to a before and after screenshot of > the website so us to visually see your changes without merging your > patch. > The easier your patch is to visually review the more feedback you'll get on it. > > Regards, > Paul Dragoonis. > >> >> [ricky@rhelpad01 phpweb] $ svn diff >> Index: styles/theme.css >> =================================================================== >> --- styles/theme.css (revision 316472) >> +++ styles/theme.css (working copy) >> @@ -431,6 +431,9 @@ >> color: #eee; >> } >> >> +#mega-drop-down a:hover { >> + color: #999; >> +} >> >> /* {{{ The anchor for section headers */ >> a.genanchor:link, >> @@ -555,13 +558,16 @@ >> margin: 0 8px; >> } >> >> -footer a:hover, >> footer a:link, >> footer a:visited { >> color: #ccc; >> } >> >> +footer a:hover { >> + color: #888; >> +} >> >> + >> /* Elephpant photo stream */ >> >> div.elephpants { >> >> >> -- >> PHP Webmaster List Mailing List (http://www.php.net/) >> To unsubscribe, visit: http://www.php.net/unsub.php >> >> Hey, thanks for the response. Alright, here are a few screenshots of the change. Documentation tab: http://images.srv1.elrod.me/php-beta-hover-links-1.png Community tab: http://images.srv1.elrod.me/php-beta-hover-links-2.png Footer: http://images.srv1.elrod.me/php-beta-hover-links-3.png And I have attached the patch as a separate file. Again, it is a very trivial patch, but I just wanted to do something simple to get my foot in the door and learn the process, after which I'll start going through and tackling some of the items listed in the howtohelp page. -Ricky

Index: styles/theme.css =================================================================== --- styles/theme.css (revision 316552) +++ styles/theme.css (working copy) @@ -431,6 +431,9 @@ color: #eee; } +#mega-drop-down a:hover { + color: #999; +} /* {{{ The anchor for section headers */ a.genanchor:link, @@ -555,13 +558,16 @@ margin: 0 8px; } -footer a:hover, footer a:link, footer a:visited { color: #ccc; } +footer a:hover { + color: #888; +} + /* Elephpant photo stream */ div.elephpants {