Re: com web/php: Crazy amounts of refactoring. Still in progress but really needed to commit so I don't lose everything.: View/HomepageNewsView.php
downloads.php get-involved.php include/footer.inc include/header.inc include/layout.inc include/shared-manual.inc index-beta.php js/common.js
styles/bootstrap.css styles/doc.css styles/home.css styles/theme.css views/homepage/sidebar.php

On Sat, Jul 6, 2013 at 10:18 PM, Levi Morrison <levim@php.net> wrote: > Commit: 50265cbadfe35ae7f2534e589c0183a3c6dfdec4 > Author: Levi Morrison <levim@php.net> Sat, 6 Jul 2013 23:18:23 -0600 > Parents: 6b1d042465a7f42aa366f663baecef229e957332 > Branches: responsive > > Link: > http://git.php.net/?p=web/php.git;a=commitdiff;h=50265cbadfe35ae7f2534e589c0183a3c6dfdec4 > > Log: > Crazy amounts of refactoring. Still in progress but really needed to commit so I don't > lose everything. > You know with git you can commit things locally and work on it, and once its pretty you can squash your commit and change the commit message to something descriptive, and rebase your changes ontop of the current master? This has boatload of weird changes without any descriptive reason so its really hard to see if your changes accidentally broke stuff, or if you have thought about xyz.. Imagine in two years we find an issue in this commit, but we have no clue what the original intentions were so fixing it could become insane amount of work. You are doing a great work on the website, but please understand that there is a group of people that needs to understand all this, maintain it, and it needs to sustain many years to come. -Hannes