Re: com web/php: Crazy amounts of refactoring. Still in progress but really needed to commit so I don't lose everything.: View/HomepageNewsView.php
downloads.php get-involved.php include/footer.inc include/header.inc include/layout.inc include/shared-manual.inc index-beta.php js/common.js
styles/bootstrap.css styles/doc.css styles/home.css styles/theme.css views/homepage/sidebar.php

On Thu, Jul 11, 2013 at 1:53 PM, Levi Morrison <morrison.levi@gmail.com> wrote: > >> You know with git you can commit things locally and work on it, and >> once its pretty you can squash your commit and change the commit >> message to something descriptive, and rebase your changes ontop of the >> current master? > > > You probably didn't notice, but this is on the responsive branch, not the > master. I can clean this stuff up if you want when I merge back into master. Aha. Did not notice that no. Remember to send email about such changes. Communicating is a key for everything we do, and there are boatload of people on this list which every once in a while want to catch up and hack on something over a weekend. >> This has boatload of weird changes without any descriptive reason so >> its really hard to see if your changes accidentally broke stuff, or if >> you have thought about xyz.. >> Imagine in two years we find an issue in this commit, but we have no >> clue what the original intentions were so fixing it could become >> insane amount of work. > > > This is the beginning of a series of very major changes of the beta php.net. > The amount of changes between them is big. If there really is an issue in > this commit, it's likely fixed by later ones. The reason these weren't > committed to master is because there were a lot of things broken in the > changes; I wanted to fix the major issues before committing. Got it. Good call on branching it. -Hannes