Re: com web/php: Redirect AMQP pages to its github page: error.php

On Thu, May 15, 2014 at 8:58 PM, Philip Olson <philip@roshambo.org> wrote: > > On May 15, 2014, at 11:23 AM, Hannes Magnusson <hannes.magnusson@gmail.com> > wrote: > > > On Thu, May 15, 2014 at 11:07 AM, Philip Olson <philip@php.net> wrote: > >> Commit: 636a531aa68918de34ee4480f812e67679d0762a > >> Author: philip <philip@roshambo.org> Thu, 15 May 2014 > 11:07:41 -0700 > >> Parents: 6e1ead211415c4bce472f1c9a653379d44eedb04 > >> Branches: master > >> > >> Link: > > http://git.php.net/?p=web/php.git;a=commitdiff;h=636a531aa68918de34ee4480f812e67679d0762a > >> > >> Log: > >> Redirect AMQP pages to its github page > >> > > > > > > I don't think this is a good idea at all. > > We didn't even do this when smarty.php.net left... Also, people will > > get used to doing php.net/amqp and getting the redirect and then be > > pissed off when it no longer works. > > > > Also. The github repo you are redirecting to is _NOT_ the one > > maintained on pecl.php.net. That website link points to: > > http://pecl.php.net/package/amqp > > > > I think this should be reverted. > > Hello Hannes, > > I think it’s a reasonable addition, and it does include a > status_header(404) call. that won't work: mirror_redirect() sets the Location header which also causes the http status to be changed to 302, while status_header() sets the Status header to 404, so they are mutually exclusive in the HTTP spec. -- Ferenc Kovács @Tyr43l - http://tyrael.hu