Re: com web/bugs: Workaround for side report from bug #67513:include/functions.php

Hello folks! I've commited this as a temporary [really ;)] workaround for side bug reported here: https://bugs.php.net/bug.php?id=67513 As reporter wrote:

(On an unrelated note, the issue tracker refused to accept my submission if I selected 'Irrelevant' as the PHP version. Therefore this bug is randomly logged against a random PHP version)

This bug is caused by pull request merged recently because it fails on our custom versions like "Irrelevant" and "str_size_and_int64 branch". As my solution is poor and may lead to further problems (one more place to check), I have following idea: couldn't we add custom versions in includes/php_versions.php and then just generate them with foreach in show_version_options()? It seems to be more elegant way to achieve this. However, I know that web-bugs is rather complex system so I wanted to consult with you to avoid unexpected bugs (like I did week ago or so). What do you think? Thanks, Maciej.

Commit:    8a32bb505a43947787932ebe14500bd74b4db973
Author:    Sobak <msobaczewski@gmail.com>         Wed, 25 Jun 2014 18:01:45 +0200

Parents: 1b0afc01e61a1b85fcaca36134befe3029dced84 Branches: master

Link:       http://git.php.net/?p=web/bugs.git;a=commitdiff;h=8a32bb505a43947787932ebe14500bd74b4db973

Log: Workaround for side report from bug #67513 Bugs: https://bugs.php.net/67513 Changed paths: M include/functions.php Diff: diff --git a/include/functions.php b/include/functions.php index 81d3de8..8c18f09 100644 --- a/include/functions.php +++ b/include/functions.php @@ -1309,6 +1309,10 @@ function incoming_details_are_valid($in, $initial = 0, $logged_in = false) } require_once "{$ROOT_DIR}/include/php_versions.php"; + + // Workaround for side report from bug #67513 + $versions = array_merge($versions, ['str_size_and_int64 branch', 'Irrelevant']); + if (empty($in['php_version']) || ($initial && !in_array($in['php_version'], $versions))) { $errors[] = 'Please select a valid PHP version.'; }