Re: com web/php: Add Twitter icon to the home page, linking to @official_php.: fonts/Font-Awesome/LICENSE.txt fonts/Font-Awesome/config.json
fonts/Font-Awesome/css/animation.css fonts/Font-Awesome/css/fontello-codes.css fonts/Font-Awesome/css/fontello-embedded.css
fonts/Font-Awesome/css/fontello-ie7-codes.css fonts/Font-Awesome/css/fontello-ie7.css fonts/Font-Awesome/css/fontello.css
fonts/Font-Awesome/font/fontello.eot fonts/Font-Awesome/font/fontel

On Wed, Jul 2, 2014 at 4:19 PM, Adam Harvey <aharvey@php.net> wrote: > Commit: 5335474af5a3b8d75948b11bc5599d69561494c2 > Author: Adam Harvey <aharvey@php.net> Wed, 2 Jul 2014 15:19:25 -0700 > Parents: d8cabbe2f9c579f2ffd314abe38dcf717193cfc5 > Branches: master > > Link: > http://git.php.net/?p=web/php.git;a=commitdiff;h=5335474af5a3b8d75948b11bc5599d69561494c2 > > Log: > Add Twitter icon to the home page, linking to @official_php. > > I've deliberately implemented this in such a way as to allow for further social > media buttons down the track if we want. I've also kept it intentionally > unobtrusive: it's there (previously, we only mentioned the Twitter account on > the mailing lists page, which was weird), but pretty subtle in the sidebar. > > There's one additional dependency: a one glyph subset of Font Awesome (created > using Fontello) containing the Twitter icon. (Should we later want to include > other icons from Font Awesome, fonts/Font-Awesome/config.json can be fed back > into Fontello as a starting point.) The additional style sheet and font file > are cached correctly, and once loaded by the user, shouldn't need to be loaded > again, as with Fira Sans. On a cold page load, this adds two requests and just > under 3 kB to the page load. > > I consider all of this reasonable, both technically and in terms of promoting > @official_php a little more, but I won't be terribly offended if someone wants > to revert this. I am trying to optimize our load times at the moment. I measured this at 4KB and not 3KB (not a huge difference). An SVG icon I have weighs in at 1.3KB. This would also be a single load, and just one. I'm not sure I'll actually go through with a change, but I am considering it. I'll do some of the other improvements first, but what do you think of this change, Adam?