Re: Re: Problems with the mailing list [was: Re: [PHP-DEV] Request for karma to vote on RFCs]

> On Jul 22, 2021, at 17:32, Ben Ramsey <ben@benramsey.com> wrote: > >  >> On Jul 22, 2021, at 16:59, Mike Schinkel <mike@newclarity.net> wrote: >> >>  >>> >>>> On Jul 22, 2021, at 3:53 PM, Mike Schinkel <mike@newclarity.net> wrote: >>>> >>>>> On Jul 22, 2021, at 1:53 PM, Tiffany Taylor <tiffany.k.taylor@gmail.com> >>>>> wrote: >>>> >>>> On Tue, Jul 20, 2021 at 2:33 AM Peter Bowyer <phpmailinglists@gmail.com> >>>> wrote: >>>> >>>>>>> Currently there are people with voting permissions that do vote, yet do >>>>> not interact with RFCs or the mailing list. >>>>> >>>>>> On Mon, 19 Jul 2021 at 23:34, Bob Magic <bob@majdak.net> wrote: >>>>>> >>>>>>> i'd say we need something more modern and transparent than this >>>>>>> old >>>>>> mailing >>>>>>> list, but i completely lack a suggestion that isn't somehow worse >>>>>>> than >>>>>> what >>>>>>> we got now in terms of massively multiplayer discussion. >>>>>>> >>>>>> >>>>>> I have now been contacted by 2 people who tried multiple times to join this >>>>>> mailing list and cannot. >>>>>> >>>>>> It took me 5 weeks for my signup to work. During that time I emailed the >>>>>> different @php.net mailboxes related to infrastructure and/or the web and >>>>>> received no response. Eventually I managed to sign up - once I created this >>>>>> brand-new Gmail account. The signup form is unreliable. >>>>>> >>>>>> There are people wanting to take part in discussions who can't. >>>>>> >>>>>> I volunteer to help sort this. Can someone who knows the PHP group >>>>>> procedures please tell me the next steps? >>>>>> >>>>>> Peter >>>>>> >>>>> >>>>> Disclaimer: I am scanning a previous conversation while composing this >>>>> email. It has been a month since I dived into this code, so this email may >>>>> contain some inaccuracies, I ask for your patience in that regard. >>>>> >>>>> It was noted off-list that there are difficulties with subscribing to >>>>> mailing lists. Ramsey and I looked at the code about a month ago, >>>>> discovered that there are some broken bits around >>>>> >>>>> https://github.com/php/web-php/blob/7d6e63b6163e1991077822b71f7ba561e5171286/mailing-lists.php#L66-L89 >>>>> and >>>>> —Vž=õq£÷;6ñ¬c£ >>>>> https://github.com/php/web-master/blob/819070de35a7b167766d3d64cbb0b450327eed7b/public/entry/subscribe.php#L9-L14. >>>>> He was able to get the subscription code working locally while running 7.4, >>>>> but the code does not work on 8.0, due to removed functions. >>>>> See also: >>>>> https://github.com/php/web-php/blob/master/include/layout.inc#L251 >>>>> , >>>>> https://github.com/php/web-php/blob/master/mailing-lists.php#L99. >>>>> >>>>> With that said, I want to invest time to resolve this, but I am currently >>>>> working on other things, and thus haven't had time to volunteer to fix it. >>>>> I can only speak for myself, but if someone wanted to take upon themselves >>>>> to resolve this, I would greatly appreciate it. >>> >>> I am planning to work on a fix for this issue. >>> >>> Any more information I need to know about it? Especially related to testing with >>> integration to a live system and/or workflow/process that I should follow? >> >> I went ahead and looked at this, and as far as I can tell I ironically already submitted a >> PR that should fix this yesterday. >> >> https://github.com/php/web-php/pull/419 >> <https://github.com/php/web-php/pull/419> >> >> I tested it locally and I was able to get it to work with just that one change. >> >> Any chance someone could look at this PR and review it? >> >> How does code get pushed from GitHub to production? > > From my tests, the issue was that web-php isn’t submitting the correct params in the POST to > web-master. Specifically, the remote IP address is missing. I believe this is because the address is > not being forwarding properly through the proxies, so web-php doesn’t actually have the user’s > IP address to pass along in the POST. > > I think it’s been this way for a very long time, since we migrated web-php into the new > infrastructure, a few years back. > > Cheers, > Ben > We might be able to fix it by getting rid of the requirement for the remote IP address here: https://github.com/php/web-master/blob/acf9f2060aad24573df8217f17bed3e53f1d1385/public/entry/subscribe.php#L11 Cheers, Ben