Re: Problems with the mailing list [was: Re: [PHP-DEV] Request for karma to vote on RFCs]

> On Jul 22, 2021, at 6:32 PM, Ben Ramsey <ben@benramsey.com> wrote: > > From my tests, the issue was that web-php isn’t submitting the correct params in the POST to > web-master. Specifically, the remote IP address is missing. I believe this is because the address is > not being forwarding properly through the proxies, so web-php doesn’t actually have the user’s > IP address to pass along in the POST. Hi Ben, Ah, interesting. When testing locally the i2c_realip() function it was returning '::1' which I was assuming was because I was testing locally so I substituted my real IP in the debugger, and it worked. But that was not what was stopping it from working, I don't think. Reading through the code it only ensures the remote IP is not empty, otherwise it lets it through and I think the IP function should alway return a non-empty value: https://github.com/php/web-master/blob/819070de35a7b167766d3d64cbb0b450327eed7b/public/entry/subscribe.php#L9-L14 I think the problem is that the URL for submission uses HTTP, not HTTPS: https://github.com/php/web-php/blob/7d6e63b6163e1991077822b71f7ba561e5171286/mailing-lists.php#L75 When I use curl in the terminal with the HTTP URL I get back an HTML "The document has moved" page. If I change to HTTPS it works. Check my logic? I submitted another PR because it should probably be upgraded to HTTP even if its not what is needed to this this issue. https://github.com/php/web-php/pull/426 -Mike