Re: SVN commit messages

From: Date: Fri, 26 Mar 2010 21:58:46 +0000
Subject: Re: SVN commit messages
References: 1 2 3  Groups: php.webmaster 
Request: Send a blank email to php-webmaster+get-7794@lists.php.net to get a copy of this message
On 03/26/2010 01:43 PM, Gwynne Raskind wrote:
On Mar 26, 2010, at 3:45 PM, Christopher Jones wrote:
sixd                                     Fri, 26 Mar 2010 19:38:26 +0000
Revision: http://svn.php.net/viewvc?view=revision&revision=296893 Log: Fix #51220 by adding . Also improve reliability for tests using undefined behavior.
Is thre a PHP injection bug or just overzealous filtering? Every time I use "$variable" in the commit message it gets removed.
If you're committing from the shell, watch out that your -m parameter is in single quotes and not double; the shell will replace unset variable names with empty strings. I'm fairly certain the commit log string is never interpreted as PHP. -- Gwynne
Thanks Gwynne I was committing in Emacs. I'll check what my hooks are doing. -- Email: christopher.jones@oracle.com Tel: +1 650 506 8630 Blog: http://blogs.oracle.com/opal/ Free PHP Book: http://tinyurl.com/ugpomhome

« previous php.webmaster (#7794) next »