Re: [ZEND-ENGINE-CVS] cvs: ZendEngine2 / zend.c

At 22:23 04/06/2003, Marcus Börger wrote:

At 15:44 04.06.2003, Stanislav Malyshev wrote:

TCA>>     i trust you;-) but - after looking thru zend.c - i think that
TCA>>     the TLS stuff is getting more and more un-maintainable.

That's another topic. If you can restructure it - you are welcome. :)

Why should we (the ones outside Zend) ? If we try to fix or restructure anything - then we are getting ignored or told that we do voodo fixes or .....

Marcus, You committed a voodoo fix. It has nothing to do with your being in or inside Zend. The fix you committed hid a problem, and under certain circumstances made the symptoms go away. It in no way fixed it. There are maintainers/designers for the Zend code. You do have a CVS account, but your newly acquired CVS account doesn't buy you a card-blanche to start making changes without consulting first. To most of the things in the engine - there's very good reasons behind. If you don't seem to understand them at first glance, ask, look again, etc. - don't just commit 'fixes'. If that's what you're offering, then no, we're not interested. If you're offering real cooperation - i.e., raise a flag as soon as you hit something you don't understand and work it along with us to solve it - we're interested. The changes you made to the interface networking without consulting the author of the code (me in this case, asking me whether I had a reason to do it the way I did; If you had asked me, you'd get a clear 'yes' message), and the voodoo fix for assert.c are good illustrations about how one should NOT work. Instead of getting sour about this, which is easy, I suggest you take this as constructive criticism and just change the way you work with the engine (and PHP in general). As I implied in an earlier post, I think you're a very smart person, I just think you don't have much experience working within the low level engine group of PHP. Zeev