Re: [ZEND-ENGINE-CVS] cvs: ZendEngine2 / zend.c

At 10:24 06/06/2003, Thies C. Arntzen wrote:

On Thu, Jun 05, 2003 at 10:27:42PM +0300, Zeev Suraski wrote: The particular piece of code in zend.c is much trickier. We're initializing the infrastructure for making PHP in threaded environments tick, and since threaded environments are very different from multiprocess environments, there's some extra stuff we have to do. For example, here we don't just initialize the current thread's function table. We also initialize a process-wide function table, which serves as the read-only 'template' for creating new function tables every time a new thread gets started (we obviously don't need it in the Apache model, thanks to the wonders of fork()). This is something very much unique to zend.c (there are several cases of this happening there) - which is why you see this not-very-pleasant-looking piece of code. Have no worries though, as again, it's NOT growing :)

    hmm - i have no worries;-) but:

#ifdef ZTS

    zend_compiler_globals *compiler_globals;
    zend_executor_globals *executor_globals;
    void ***tsrm_ls;

#ifdef ZTS

    extern ZEND_API ts_rsrc_id ini_scanner_globals_id;
    extern ZEND_API ts_rsrc_id language_scanner_globals_id;

...

    might be a C&P thing - but it looks awful...

    GLOBAL_FUNCTION_TABLE = (HashTable *) malloc(sizeof(HashTable));
    GLOBAL_CLASS_TABLE = (HashTable *) malloc(sizeof(HashTable));
    GLOBAL_AUTO_GLOBALS_TABLE = (HashTable *) malloc(sizeof(HashTable));

#ifdef ZTS

    GLOBAL_CONSTANTS_TABLE = (HashTable *) malloc(sizeof(HashTable));

#endif

    sesame-street (do you get that in israel?) taught me how to "spot the
    differnce" but i see none between GLOBAL_FUNCTION_TABLE,
    GLOBAL_CLASS_TABLE, GLOBAL_AUTO_GLOBALS_TABLE and GLOBAL_CONSTANTS_TABLE,
    do you?

Hrm no, but that's why I said that it looks like a voodoo fix.

    it might be clear to you as the architect of Zend, but for me it's not that
    obvious, and if there is a good eplanation for this it would make sense to
    name the variables "right"

I'm not saying it's an easy-to-understand piece of code - it's a fairly complicated piece of code. But it cannot be simplified, we're doing certain initializations in there in a certain order and using a certain methodology, that doesn't exist anywhere else in PHP.

    but -then again- i have no worries.

Good :) Zeev