Re: [ZEND-ENGINE-CVS] cvs: ZendEngine2 /tests bug24773.phpt
| From: | Moriyoshi Koizumi | Date: | Thu, 04 Dec 2003 17:29:08 +0000 |
| Subject: | Re: [ZEND-ENGINE-CVS] cvs: ZendEngine2 /tests bug24773.phpt | ||
| References: | 1 2 3 4 5 | Groups: | php.zend-engine.cvs |
| Request: | Send a blank email to php-zend-engine-cvs+get-2073@lists.php.net to get a copy of this message | ||
On 2003/12/04, at 21:58, Andi Gutmans wrote:
I just looked over the code in detail. I think there's a global issue there. I am thinking of letting fetch_dimension_address() deal with E_ERRORing out and for doing so, pass it BP_VAR_UNSET and not BP_VAR_R. What do you guys think? Have time to see if that would be a cleaner more thorough fix? We would then revert the more specific patch which does an explicit check on the return value of fetch_dimension_address().Agreed. I just looked into the issue too, and reached the similar conclusion. Seems I'd better revert it then. BTW, introducing BP_VAR_UNSET doesn't look neat to me, as the generic fix for both ZE1 and ZE2 would be wanted. Moriyoshi