Re: [ZEND-ENGINE-CVS] cvs: ZendEngine2 /tests bug24773.phpt

At 02:29 AM 12/5/2003 +0900, Moriyoshi Koizumi wrote:

On 2003/12/04, at 21:58, Andi Gutmans wrote:

I just looked over the code in detail. I think there's a global issue there. I am thinking of letting fetch_dimension_address() deal with E_ERRORing out and for doing so, pass it BP_VAR_UNSET and not BP_VAR_R. What do you guys think? Have time to see if that would be a cleaner more thorough fix? We would then revert the more specific patch which does an explicit check on the return value of fetch_dimension_address().

Agreed. I just looked into the issue too, and reached the similar conclusion. Seems I'd better revert it then.

Yeah, reverting all of it is probably the best thing to do.

BTW, introducing BP_VAR_UNSET doesn't look neat to me, as the generic fix for both ZE1 and ZE2 would be wanted.

I think for ZE2 we should definitely do it the right way and use BP_VAR_UNSET. It will be clean and we'll E_ERROR out at the right time. If you have time and want to experiment with a patch in this direction that would be great. If you do so, please send it for review before committing because you must have realized by now, this code isn't that easy to get right :) Andi