Re: [ZEND-ENGINE-CVS] cvs: ZendEngine2 / zend_API.c
| From: | Marcus Boerger | Date: | Wed, 22 Sep 2004 20:46:50 +0000 |
| Subject: | Re: [ZEND-ENGINE-CVS] cvs: ZendEngine2 / zend_API.c | ||
| References: | 1 2 | Groups: | php.zend-engine.cvs |
| Request: | Send a blank email to php-zend-engine-cvs+get-3010@lists.php.net to get a copy of this message | ||
Hello Andi,
not exactly the same. We need to align the '#' of pre-compiler commands
to column 1. If not a few older compilers will fail to compile PHP.
however using '#if defined(x) && defined(y) ....' is much easier to read.
best regards
marcus
Wednesday, September 22, 2004, 8:05:21 PM, you wrote:
> At 02:31 PM 9/22/2004 +0000, Anantha Kesari H Y wrote:
>>+#ifdef NETWARE
>>+#ifdef APACHE_2_BUILD
>>+ if (module->handle) {
>>+ dlclose(module->handle);
>>+ }
>>+#endif
>>+#else
>>+ if (module->handle) {
>>+ dlclose(module->handle);
>>+ }
>>+#endif
>> #endif
> Am I blind or is this the same? Can you please explain this patch?
> And I also suggest to use the following in future: #if defined(NETWARE) &&
> defined(APACHE_2_BUILD)
> Andi
--
Best regards,
Marcus mailto:helly@php.net