Re: [ZEND-ENGINE-CVS] cvs: ZendEngine2 / zend_API.c
| From: | Andi Gutmans | Date: | Thu, 23 Sep 2004 21:24:51 +0000 |
| Subject: | Re: [ZEND-ENGINE-CVS] cvs: ZendEngine2 / zend_API.c | ||
| References: | 1 2 | Groups: | php.zend-engine.cvs |
| Request: | Send a blank email to php-zend-engine-cvs+get-3018@lists.php.net to get a copy of this message | ||
So why not
#if !(defined(NETWARE) && defined(APACHE_2_BUILD))
if (module->handle) {
dlclose(module->handle);} #endif Don't need to duplicate code in this case. Andi At 12:46 AM 9/23/2004 -0700, Kamesh Jayachandran wrote:
Hi Andi, There is a catch. We want to call dlclose(module->handle); for Apache2 on NetWare not for Apache1.3 on NetWare. The code seletively leaves out dlclose APACHE1.3 build on. I did not want to put ifndef NETWARE because I didn't want to assume about other OSes. Let me know in case of better ways of doing the same. With regards Kamesh Jayachandran On Wed, 22 Sep 2004 11:05:21 -0700, "Andi Gutmans" <andi@zend.com> said: At 02:31 PM 9/22/2004 +0000, Anantha Kesari H Y wrote:+#ifdef NETWARE +#ifdef APACHE_2_BUILDAm I blind or is this the same? Can you please explain this patch? And I also suggest to use the following in future: #if defined(NETWARE) && defined(APACHE_2_BUILD) Andi -- Zend Engine CVS Mailing List (http://cvs.php.net/) To unsubscribe, visit: http://www.php.net/unsub.php+ if (module->handle) { + dlclose(module->handle); + }+#endif +#else+ if (module->handle) { + dlclose(module->handle); + }+#endif #endif