RE: [ZEND-ENGINE-CVS] cvs: ZendEngine2 / zend_builtin_functions.c php-src NEWS
| From: | Derick Rethans | Date: | Mon, 31 Oct 2005 20:31:58 +0000 |
| Subject: | RE: [ZEND-ENGINE-CVS] cvs: ZendEngine2 / zend_builtin_functions.c php-src NEWS | ||
| References: | 1 | Groups: | php.zend-engine.cvs |
| Request: | Send a blank email to php-zend-engine-cvs+get-4302@lists.php.net to get a copy of this message | ||
On Mon, 31 Oct 2005, Dmitry Stogov wrote:
> The problem is conceptual.
> Before this patch PHP looked for EG(exception) after calling constructor and
> disabled destructor calling.
>
> if (EG(exception) && ctor_opline) {
> if (RETURN_VALUE_USED(ctor_opline)) {
> EG(This)->refcount--;
> }
> if (EG(This)->refcount == 1) {
> zend_object_store_ctor_failed(EG(This) TSRMLS_CC);
> }
> }
>
> Now the object also stored in backtrace so refcount is more then 1.
> Probably we can check refcount with 2, but I am not sure that is a proper
> way.
We can also revert it simply, as I don't see a huge point in having the
object *itself* in the backtrace...
Derick
--
Derick Rethans
http://derickrethans.nl | http://ez.no | http://xdebug.org