Re: [ZEND-ENGINE-CVS] cvs: ZendEngine2 / zend_builtin_functions.c php-src NEWS

Hello Dmitry, two things - we can store whether the dtor was called or ctor failed easily in the objects flag right where in_set/in_get reside. - if recount is 1 then the object must not be stored in the exception because it will get destructed and must therefore of course not stored in the exception. That on the other hand means the first thing is not necessary. marcus Monday, October 31, 2005, 9:35:21 PM, you wrote: >> -----Original Message----- >> From: Derick Rethans [mailto:derick@php.net] >> Sent: Monday, October 31, 2005 11:32 PM >> To: Dmitry Stogov >> Cc: 'Zeev Suraski'; 'Sebastian Bergmann'; >> zend-engine-cvs@lists.php.net; 'Andi Gutmans'; 'Marcus >> Boerger'; 'Ilia Alshanetsky' >> Subject: RE: [ZEND-ENGINE-CVS] cvs: ZendEngine2 / >> zend_builtin_functions.c php-src NEWS >> >> >> On Mon, 31 Oct 2005, Dmitry Stogov wrote: >> >> > The problem is conceptual. >> > Before this patch PHP looked for EG(exception) after calling >> > constructor and disabled destructor calling. >> > >> > if (EG(exception) && ctor_opline) { >> > if (RETURN_VALUE_USED(ctor_opline)) { >> > EG(This)->refcount--; >> > } >> > if (EG(This)->refcount == 1) { >> > zend_object_store_ctor_failed(EG(This) TSRMLS_CC); >> > } >> > } >> > >> > Now the object also stored in backtrace so refcount is more then 1. >> > Probably we can check refcount with 2, but I am not sure that is a >> > proper way. >> >> We can also revert it simply, as I don't see a huge point in >> having the >> object *itself* in the backtrace... >> >> Derick > Of course we can. :) > But probably $this can be really useful in debug backtrace. > Dmitry. Best regards, Marcus