Re: [ZEND-ENGINE-CVS] cvs: Zend / zend_execute.c zend_execute.h
| From: | Derick Rethans | Date: | Tue, 01 Oct 2002 15:19:41 +0000 |
| Subject: | Re: [ZEND-ENGINE-CVS] cvs: Zend / zend_execute.c zend_execute.h | ||
| References: | 1 | Groups: | php.zend-engine.cvs |
| Request: | Send a blank email to php-zend-engine-cvs+get-459@lists.php.net to get a copy of this message | ||
On Tue, 1 Oct 2002, Zeev Suraski wrote:
> zeev Tue Oct 1 11:03:04 2002 EDT
>
> Modified files:
> /Zend zend_execute.c zend_execute.h
> Log:
> execute_internal() shouldn't be exposed. Thies - if you think it SHOULD be
> exposed for some reason, then it should move to zend_execute_API.c
It should be exposed so that extensions can hook into this. You just
broke some extensions here :)
Derick
>
>
> Index: Zend/zend_execute.c
> diff -u Zend/zend_execute.c:1.310 Zend/zend_execute.c:1.311
> --- Zend/zend_execute.c:1.310 Thu Sep 26 14:39:28 2002
> +++ Zend/zend_execute.c Tue Oct 1 11:03:03 2002
> @@ -994,7 +994,7 @@
> EX(opline)++; \
> continue;
>
> -ZEND_API void execute_internal(zend_execute_data *execute_data_ptr, int return_value_used
> TSRMLS_DC)
> +void execute_internal(zend_execute_data *execute_data_ptr, int return_value_used TSRMLS_DC)
> {
> ((zend_internal_function *)
> execute_data_ptr->function_state.function)->handler(execute_data_ptr->opline->extended_value,
> execute_data_ptr->Ts[execute_data_ptr->opline->result.u.var].var.ptr,
> execute_data_ptr->object.ptr, return_value_used TSRMLS_CC);
> }
> Index: Zend/zend_execute.h
> diff -u Zend/zend_execute.h:1.45 Zend/zend_execute.h:1.46
> --- Zend/zend_execute.h:1.45 Sat Aug 24 13:51:50 2002
> +++ Zend/zend_execute.h Tue Oct 1 11:03:03 2002
> @@ -34,8 +34,8 @@
> void init_executor(TSRMLS_D);
> void shutdown_executor(TSRMLS_D);
> ZEND_API void execute(zend_op_array *op_array TSRMLS_DC);
> -ZEND_API void execute_internal(zend_execute_data *execute_data_ptr, int return_value_used
> TSRMLS_DC);
> ZEND_API int zend_is_true(zval *op);
> +void execute_internal(zend_execute_data *execute_data_ptr, int return_value_used TSRMLS_DC);
> static inline void safe_free_zval_ptr(zval *p)
> {
> TSRMLS_FETCH();
>
>
>
> --
> Zend Engine CVS Mailing List (http://cvs.php.net/)
> To unsubscribe, visit: http://www.php.net/unsub.php
>
--
---------------------------------------------------------------------------
Derick Rethans http://derickrethans.nl/
JDI Media Solutions http://www.jdimedia.nl/
---------------------------------------------------------------------------