Re: [ZEND-ENGINE-CVS] cvs: Zend / zend_execute.c zend_execute.h

At 06:07 PM 10/1/2002 +0200, Thies C. Arntzen wrote:

On Tue, Oct 01, 2002 at 06:31:49PM +0300, Zeev Suraski wrote: At 18:19 01/10/2002, Derick Rethans wrote:

On Tue, 1 Oct 2002, Zeev Suraski wrote:

zeev          Tue Oct  1 11:03:04 2002 EDT

Modified files:

    /Zend     zend_execute.c zend_execute.h

Log: execute_internal() shouldn't be exposed. Thies - if you think it

SHOULD be

exposed for some reason, then it should move to zend_execute_API.c

It should be exposed so that extensions can hook into this. You just broke some extensions here :)

I thought you'd hook through zend_execute_internal, and not execute_internal. Anyway, if you really do need execute_internal, then we can move it to zend_execute_API.c.

    you do hook into zend_execute_internal, but you still need to
    be able to perform call the "real-thing", which is
    execute_internal in this case. i modelled it after the
    zend_execute and execute naming you choose in the 1st place.

Wouldn't you normally "stack" the calls and save the current zend_execute_internal in an internal variable and then override zend_execute_internal with a function which runs your code and calls the saved old one? I don't think moving it to execute_API is necessary. Andi