Req #73385 [Opn->Fbk]: xxhash for hash extension

Edit report at https://bugs.php.net/bug.php?id=73385&edit=1 ID: 73385 Updated by: krakjoe@php.net Reported by: spam2 at rhsoft dot net Summary: xxhash for hash extension -Status: Open +Status: Feedback Type: Feature/Change Request Package: hash related PHP Version: Irrelevant Block user comment: N Private report: N New Comment: Branches below 7.2 are supposed to be in feature freeze. At least a pull request is required to add the new feature, this bug tracker does not generate the kind of consensus we require for adding this kind of new feature. Please contact the author and request that a pull request is made on github. Previous Comments: ------------------------------------------------------------------------ [2016-11-14 10:51:36] spam2 at rhsoft dot net why should the author make a RFC when the code exists and can be merged and why does that need to wait until 7.2 ------------------------------------------------------------------------ [2016-10-27 23:15:34] yohgaki@php.net Simple hash function addition to hash() function could be simply merged. There are number of useful hash functions out there. We may not want RFC for each of them. We may have RFC only when there is objection for adding new one. I don't have a strong opinion for RFC requirement such changes, though. ------------------------------------------------------------------------ [2016-10-26 09:17:20] kalle@php.net Maybe you could contact the author and ask him to make an RFC and merge with the existing ext/hash extension, seems like an excellent inclusion for 7.2 ------------------------------------------------------------------------ [2016-10-25 09:03:53] spam2 at rhsoft dot net Description: ------------ https://github.com/stuartherbert/php-xxhash since we have now hash(ALGO, data) and hash_file(ALGO, data) and hash_algos() it would make more sense to have it as another algorithm than a out-of-tree module the main usecase i see here is for etag-headers which needs to be fast and are not very collision critical in real life ------------------------------------------------------------------------ -- Edit this bug report at https://bugs.php.net/bug.php?id=73385&edit=1