Req #73385 [Opn]: xxhash for hash extension
| From: | spam2 at rhsoft dot net | Date: | Fri, 17 Feb 2017 09:07:56 +0000 |
| Subject: | Req #73385 [Opn]: xxhash for hash extension | ||
| References: | 1 | Groups: | php.bugs |
| Request: | Send a blank email to php-bugs+get-207423@lists.php.net to get a copy of this message | ||
Edit report at https://bugs.php.net/bug.php?id=73385&edit=1
ID: 73385
User updated by: spam2 at rhsoft dot net
Reported by: spam2 at rhsoft dot net
Summary: xxhash for hash extension
Status: Open
Type: Feature/Change Request
Package: hash related
PHP Version: Irrelevant
Block user comment: N
Private report: N
New Comment:
> Branches below 7.2 are supposed to be in feature freeze
seriously?
when it's no problem to add a hash-related function to the core namespace how in the world is
it a problem to add a algo where code already exists to that same codebase?
http://www.php.net/ChangeLog-7.php#7.1.2
Hash:
Added hash_hkdf() function.
Fixed bug #73961 (environmental build dependency in hash sha3 source).
Previous Comments:
------------------------------------------------------------------------
[2017-01-16 08:54:13] spam2 at rhsoft dot net
What about the maintainer of ext/hash doing so - it makes little sense for users to sit in the
middle of communication
------------------------------------------------------------------------
[2017-01-16 05:14:05] krakjoe@php.net
Branches below 7.2 are supposed to be in feature freeze.
At least a pull request is required to add the new feature, this bug tracker does not generate the
kind of consensus we require for adding this kind of new feature.
Please contact the author and request that a pull request is made on github.
------------------------------------------------------------------------
[2016-11-14 10:51:36] spam2 at rhsoft dot net
why should the author make a RFC when the code exists and can be merged
and why does that need to wait until 7.2
------------------------------------------------------------------------
[2016-10-27 23:15:34] yohgaki@php.net
Simple hash function addition to hash() function could be simply merged. There are number of useful
hash functions out there. We may not want RFC for each of them. We may have RFC only when there is
objection for adding new one.
I don't have a strong opinion for RFC requirement such changes, though.
------------------------------------------------------------------------
[2016-10-26 09:17:20] kalle@php.net
Maybe you could contact the author and ask him to make an RFC and merge with the existing ext/hash
extension, seems like an excellent inclusion for 7.2
------------------------------------------------------------------------
The remainder of the comments for this report are too long. To view
the rest of the comments, please view the bug report online at
https://bugs.php.net/bug.php?id=73385
--
Edit this bug report at https://bugs.php.net/bug.php?id=73385&edit=1