Req #73385 [Opn->Csd]: xxhash for hash extension

Edit report at https://bugs.php.net/bug.php?id=73385&edit=1 ID: 73385 Updated by: ab@php.net Reported by: spam2 at rhsoft dot net Summary: xxhash for hash extension -Status: Open +Status: Closed Type: Feature/Change Request Package: hash related PHP Version: Irrelevant -Assigned To: +Assigned To: ab Block user comment: N Private report: N New Comment: xxHash landed in master. Thanks Previous Comments: ------------------------------------------------------------------------ [2017-02-17 09:07:52] spam2 at rhsoft dot net > Branches below 7.2 are supposed to be in feature freeze seriously? when it's no problem to add a hash-related function to the core namespace how in the world is it a problem to add a algo where code already exists to that same codebase? http://www.php.net/ChangeLog-7.php#7.1.2 Hash: Added hash_hkdf() function. Fixed bug #73961 (environmental build dependency in hash sha3 source). ------------------------------------------------------------------------ [2017-01-16 08:54:13] spam2 at rhsoft dot net What about the maintainer of ext/hash doing so - it makes little sense for users to sit in the middle of communication ------------------------------------------------------------------------ [2017-01-16 05:14:05] krakjoe@php.net Branches below 7.2 are supposed to be in feature freeze. At least a pull request is required to add the new feature, this bug tracker does not generate the kind of consensus we require for adding this kind of new feature. Please contact the author and request that a pull request is made on github. ------------------------------------------------------------------------ [2016-11-14 10:51:36] spam2 at rhsoft dot net why should the author make a RFC when the code exists and can be merged and why does that need to wait until 7.2 ------------------------------------------------------------------------ [2016-10-27 23:15:34] yohgaki@php.net Simple hash function addition to hash() function could be simply merged. There are number of useful hash functions out there. We may not want RFC for each of them. We may have RFC only when there is objection for adding new one. I don't have a strong opinion for RFC requirement such changes, though. ------------------------------------------------------------------------ The remainder of the comments for this report are too long. To view the rest of the comments, please view the bug report online at https://bugs.php.net/bug.php?id=73385 -- Edit this bug report at https://bugs.php.net/bug.php?id=73385&edit=1