Bug #77653 [Asn]: php-fpm, operator displayed instead of the real error message

Edit report at https://bugs.php.net/bug.php?id=77653&edit=1 ID: 77653 Updated by: bukka@php.net Reported by: claudiu_beta at yahoo dot com Summary: php-fpm, operator displayed instead of the real error message Status: Assigned Type: Bug Package: FPM related Operating System: Fedora 29 PHP Version: 7.3.3RC1 Assigned To: bukka Block user comment: N Private report: N New Comment: Thanks for testing! It looks like reusing output pipe for signalling request end is not a really good solution. I need to address it in a better way. Previous Comments: ------------------------------------------------------------------------ [2019-04-04 06:11:32] claudiu_beta at yahoo dot com A new example with php 7.3.4 and patch applied, thanks to Remi. Now the binary content ^@ is mixed with this text "fscf". [04-Apr-2019 07:15:40] WARNING: [pool otherdomain] child 19148 said into stderr: "^@fscf^@^@fscf^@^@fscf^@" ------------------------------------------------------------------------ [2019-04-02 04:09:57] claudiu_beta at yahoo dot com Previous: [01-Apr-2019 04:50:43] WARNING: [pool domainx] child 5247 said into stderr: "^@" With the patch applied: [02-Apr-2019 00:30:46] WARNING: [pool domainx] child 17022 said into stderr: "^@fscf^@" ------------------------------------------------------------------------ [2019-04-01 14:14:34] claudiu_beta at yahoo dot com Thanks Remi. I have installed 7.3.4~RC1-3. Now I need some time for tests. ------------------------------------------------------------------------ [2019-04-01 12:58:00] remi@php.net @claudiu_beta as you are using packages from my repository, can you please test "7.3.4~RC1-3" from "remi-test" which includes the proposal fix from @bukka ? ------------------------------------------------------------------------ [2019-03-31 16:58:59] bukka@php.net @nikic Ah good spot. Seems like I didn't realised that the log IO can get appended so the extra \0 can be at the beginning. It's definitely a bug and might be also the cause of this report. The flushing is important if multiple messages without new line at the end are logged. It can be seen in this test: https://github.com/php/php-src/blob/06dd1d78a7ec1678b53ef657033c2021f4dc902f/sapi/fpm/tests/log-bwd-multiple-msgs.phpt . If it wasn't flushed, then part of the unfinished string could be carried on to the next request. I just created a PR which introduced a bit more flexible way of flushing where it's checked at beginning and the end of the logged data in the event. I also moved the flush after shutdown which should probably have the main effect. ------------------------------------------------------------------------ The remainder of the comments for this report are too long. To view the rest of the comments, please view the bug report online at https://bugs.php.net/bug.php?id=77653 -- Edit this bug report at https://bugs.php.net/bug.php?id=77653&edit=1