Edit report at https://bugs.php.net/bug.php?id=77653&edit=1
ID: 77653
User updated by: claudiu_beta at yahoo dot com
Reported by: claudiu_beta at yahoo dot com
Summary: php-fpm, operator displayed instead of the real
error message
Status: Assigned
Type: Bug
Package: FPM related
Operating System: Fedora 29
PHP Version: 7.3.3RC1
Assigned To: bukka
Block user comment: N
Private report: N
New Comment:
I have tested the patched version from Remi for few days and I no longer have those binary error
messages. Actually, I don't have errors anymore, with or without binary content, for pools
where they appeared in the past. Maybe these error messages are completely suppressed to show
nothing when they should?
Previous Comments:
------------------------------------------------------------------------
[2019-06-05 15:26:52] nikic@php.net
Likely related, we regularly see sapi/fpm/tests/log-bwd-multiple-msgs.phpt failing on Azure with:
001+ ERROR: The actual string(43) does not match expected string(21):
002+ - EXPECT: 'msg 1 - msg 2 - msg 3'
003+ - ACTUAL: 'msg 1 - msg 2 - msg 3[[0x00]]msg 1 - msg 2 - msg 3'
004+ ERROR: Unexpected line: [05-Jun-2019 13:38:23] NOTICE: Terminating ...
005+
------------------------------------------------------------------------
[2019-06-04 18:20:52] claudiu_beta at yahoo dot com
I will install this test version from Remi's repo for few days, then I will post the result.
------------------------------------------------------------------------
[2019-06-04 15:27:05] remi@php.net
@claudiu_beta as you are using packages from my repository, can you please test "7.3.6-2"
from "remi-test" which includes the new proposal fix from @bukka ?
@bukka sorry for the delay... quite busy these days.
(P.S. build available for F29, F30 and EL7)
------------------------------------------------------------------------
[2019-05-27 16:12:11] bukka@php.net
I just pushed another attempt to fix this to the PR. I also pinged Remi if he could kindly create
another RPM to test.
------------------------------------------------------------------------
[2019-05-05 15:59:59] bukka@php.net
Ok thanks again for testing! Indeed it will result in quite a few new open file descriptor -
basically one for each child in the master process which might be quite a lot if you are using
around 1000 pools which means even more children. So this is not probably good idea either.
So it seems like the markers in the output are the only possible solution for flushing. I think
there are some issues in the logic atm. - the whole read loop is a bit messy so I will try to
improve it and see if it addresses the issue. The thing that it definitely goes through that logic
as the message is still decorated by zlog...
------------------------------------------------------------------------
The remainder of the comments for this report are too long. To view
the rest of the comments, please view the bug report online at
https://bugs.php.net/bug.php?id=77653
--
Edit this bug report at https://bugs.php.net/bug.php?id=77653&edit=1