Edit report at https://bugs.php.net/bug.php?id=77653&edit=1
ID: 77653
Updated by: bukka@php.net
Reported by: claudiu_beta at yahoo dot com
Summary: php-fpm, operator displayed instead of the real
error message
Status: Assigned
Type: Bug
Package: FPM related
Operating System: Fedora 29
PHP Version: 7.3.3RC1
Assigned To: bukka
Block user comment: N
Private report: N
New Comment:
All the "^@" should disappear as they were supposed to be used just for flushing but due
to incorrect logic fpm_stdio, they were visible. So it's good that they are not visible now.
The permission error should be unrelated but as you can still see some, then I don't think it
hides them.
I need to fix one small case in the PR when the flush character is in between two buffers but then I
think it seems good so I will probably merge it.
Previous Comments:
------------------------------------------------------------------------
[2019-06-16 20:36:23] claudiu_beta at yahoo dot com
The incidence of this error is very rare, at least with this latest 7.3.6 version. For this reason,
my tests may not be very accurate.
I have some observations though:
1. I no longer have any "strange" error in binary format.
2. In the past, I had errors like
[26-May-2019 12:57:11] WARNING: [pool www.xyz] child 6697 said into stderr: "^@"
and lots of " said into stderr: ... (Permission denied)" errors.
For the last 10 days, I only have few lines with errors displayed correctly
said into stderr: "ERROR: Unable to open primary script: xxxxxxxxxxx (Permission denied)"
Nothing more and not a single trace about the old error.
My conclusion:
1. Issues causing the errors have been solved in the meantime and patch is correct.
2. Or maybe till now the errors were logged in "error" and patch is ok.
3. Or maybe all related errors are now completely suppressed and patch is just hiding the errors.
------------------------------------------------------------------------
[2019-06-16 19:14:54] bukka@php.net
Thanks again for testing! What kind of errors? If it's just the empty string logs, then I think
it should disappear. You should still see the massages though. What exactly is different before and
after the patch?
------------------------------------------------------------------------
[2019-06-10 20:39:30] claudiu_beta at yahoo dot com
I have tested the patched version from Remi for few days and I no longer have those binary error
messages. Actually, I don't have errors anymore, with or without binary content, for pools
where they appeared in the past. Maybe these error messages are completely suppressed to show
nothing when they should?
------------------------------------------------------------------------
[2019-06-05 15:26:52] nikic@php.net
Likely related, we regularly see sapi/fpm/tests/log-bwd-multiple-msgs.phpt failing on Azure with:
001+ ERROR: The actual string(43) does not match expected string(21):
002+ - EXPECT: 'msg 1 - msg 2 - msg 3'
003+ - ACTUAL: 'msg 1 - msg 2 - msg 3[[0x00]]msg 1 - msg 2 - msg 3'
004+ ERROR: Unexpected line: [05-Jun-2019 13:38:23] NOTICE: Terminating ...
005+
------------------------------------------------------------------------
[2019-06-04 18:20:52] claudiu_beta at yahoo dot com
I will install this test version from Remi's repo for few days, then I will post the result.
------------------------------------------------------------------------
The remainder of the comments for this report are too long. To view
the rest of the comments, please view the bug report online at
https://bugs.php.net/bug.php?id=77653
--
Edit this bug report at https://bugs.php.net/bug.php?id=77653&edit=1