Edit report at https://bugs.php.net/bug.php?id=81390&edit=1
ID: 81390
Updated by: alexdowad@php.net
Reported by: alec at alec dot pl
Summary: mb_detect_encoding() regression
-Status: Assigned
+Status: Closed
Type: Bug
Package: mbstring related
PHP Version: 8.1.0beta3
Assigned To: alexdowad
Block user comment: N
Private report: N
New Comment:
Closing this for now, as I believe the enhancements which have been merged in to mainline will fully
address Alec's concerns. (Whenever a new public release comes out which he can install and try,
that is.)
Alec, please re-open this if you still discover any problems with the detection accuracy of
mb_detect_encoding() in the next rc release. On the other hand, if it works well for you, please
drop a line as well.
Previous Comments:
------------------------------------------------------------------------
[2021-10-17 18:48:44] alexdowad@php.net
https://github.com/php/php-src/pull/7587
------------------------------------------------------------------------
[2021-10-17 17:20:44] alexdowad@php.net
Hi Alec,
The test case which you provided in the original bug report does appear to return good results now.
Looks like the bug fix had a good effect:
https://3v4l.org/UXtBd
Thank you for providing more test cases in which the latest implementation of mb_detect_encoding
does not return accurate results. Those will be added to the test suite for the PHP interpreter.
I have been working on another patch for mbstring which significantly enhances the accuracy of
legacy encoding detection. Several of the test cases you have added in this thread already return
the correct result with that new patch.
Once the next patch is merged, we would appreciate your further assistance with testing. If you are
able to build PHP from source, it would be even more helpful if you can test even before the next
rc. However, I understand that building a C program may seem daunting for some who have never done
that before, and it is work which you didn't sign up for.
------------------------------------------------------------------------
[2021-10-15 11:17:16] alec at alec dot pl
Another one:
https://3v4l.org/QK7q6
------------------------------------------------------------------------
[2021-10-15 09:46:43] alec at alec dot pl
Another case:
https://3v4l.org/ritGP
------------------------------------------------------------------------
[2021-10-15 07:47:28] alec at alec dot pl
I don't know what's going on, but I now have rc4 and this is still not fixed.
https://3v4l.org/lfM8J
https://3v4l.org/0enJ8
3v4l does not have rc4 yet, but it was supposed to be fixed in rc3. Looks it isn't.
------------------------------------------------------------------------
The remainder of the comments for this report are too long. To view
the rest of the comments, please view the bug report online at
https://bugs.php.net/bug.php?id=81390
--
Edit this bug report at https://bugs.php.net/bug.php?id=81390&edit=1