Re: cvs: php4 /main php.h

Hmm maybe there were warnings I didn't see. I might have missed them. Sebastian? Andi At 17:43 15/03/2002 +0900, Yasuo Ohgaki wrote:

Andi Gutmans wrote:

What warnings? I fixed a redefinition warning a couple of days ago. Andi

Sebastian complained there are so many warning. I thought it's from VC. On Fri, 15 Mar 2002, Yasuo Ohgaki wrote: Sebastian Bergmann wrote:

As of yesterday, I get a lot of these

    main\php.h(70): warning C4005: 'NDEBUG': Macro redefined

It seems VC does not support assert() macro as UNIX does... I changed it UNIX only for now. I don't use VC. So please fix the warnings or any other problem, related to assert for VC. Thank you. -- Yasuo Ohgaki

At 06:36 15/03/2002 +0000, Yasuo Ohgaki wrote:

yohgaki         Fri Mar 15 01:36:56 2002 EDT

Modified files:

    /php4/main  php.h

Log: Avoid warnings under VC. # If you know how assert() should be used under VC, please fix it. Index: php4/main/php.h diff -u php4/main/php.h:1.160 php4/main/php.h:1.161

--- php4/main/php.h:1.160       Wed Mar 13 21:17:23 2002
+++ php4/main/php.h     Fri Mar 15 01:36:56 2002

@@ -17,7 +17,7 @@ +----------------------------------------------------------------------+ */ -/* $Id: php.h,v 1.160 2002/03/14 02:17:23 yohgaki Exp $ */ +/* $Id: php.h,v 1.161 2002/03/15 06:36:56 yohgaki Exp $ */ #ifndef PHP_H #define PHP_H @@ -63,6 +63,7 @@ #include "php_regex.h" +#ifndef PHP_WIN32 #if HAVE_ASSERT_H #if PHP_DEBUG #undef NDEBUG @@ -73,6 +74,7 @@ #else /* HAVE_ASSERT_H */ #define assert(expr) ((void) (0)) #endif /* HAVE_ASSERT_H */ +#endif /* PHP_WIN32 */ #define APACHE 0 -- PHP CVS Mailing List (http://www.php.net/) To unsubscribe, visit: http://www.php.net/unsub.php