Re: cvs: php4 /main php.h

> I don't find it a good idea to commit around things you can't > really test ... (just my opinion). > Then I cannot commit any :) All of us have VC handy? People who have VC does always build under VC? I guess not. I suppose you are doing ;) PS: I've posted the idea once, and patch once. -- Yasuo Ohgaki > - Markus > > On Fri, Mar 15, 2002 at 06:36:56AM -0000, Yasuo Ohgaki wrote : > > yohgaki Fri Mar 15 01:36:56 2002 EDT > > > > Modified files: > > /php4/main php.h > > Log: > > Avoid warnings under VC. > > # If you know how assert() should be used under VC, please fix it. > > > > > > Index: php4/main/php.h > > diff -u php4/main/php.h:1.160 php4/main/php.h:1.161 > > --- php4/main/php.h:1.160 Wed Mar 13 21:17:23 2002 > > +++ php4/main/php.h Fri Mar 15 01:36:56 2002 > > @@ -17,7 +17,7 @@ > > +--------------------------------------------------------------------- -+ > > */ > > > > -/* $Id: php.h,v 1.160 2002/03/14 02:17:23 yohgaki Exp $ */ > > +/* $Id: php.h,v 1.161 2002/03/15 06:36:56 yohgaki Exp $ */ > > > > #ifndef PHP_H > > #define PHP_H > > @@ -63,6 +63,7 @@ > > > > #include "php_regex.h" > > > > +#ifndef PHP_WIN32 > > #if HAVE_ASSERT_H > > #if PHP_DEBUG > > #undef NDEBUG > > @@ -73,6 +74,7 @@ > > #else /* HAVE_ASSERT_H */ > > #define assert(expr) ((void) (0)) > > #endif /* HAVE_ASSERT_H */ > > +#endif /* PHP_WIN32 */ > > > > #define APACHE 0 > > > > > > > > > > -- > > PHP CVS Mailing List (http://www.php.net/) > > To unsubscribe, visit: http://www.php.net/unsub.php > > -- > Please always Cc to me when replying to me on the lists. > GnuPG Key: http://guru.josefine.at/~mfischer/C2272BD0.asc >