Re: cvs: php4 /main network.c

Yasuo Ohgaki wrote:

Wez, I've explained the reason why your code is questionable via. e-mail. Feel free to shoot me showing including <stddef.h> confirms ANSI C standard :)

AFAIK, stddef.h is defined by comittee X3J11. I would rather to be shot by someone, though. If it's ok to be included as standard C header in PHP, I'll clean up some code (Checking header during confiure, etc) -- Yasuo Ohgaki

PS: PHP aims to be compiled under ANSI C compiler. Is this changed? -- Yasuo Ohgaki Wez Furlong wrote:

On 16/03/02, "Yasuo Ohgaki" <yohgaki@dd.iij4u.or.jp> wrote:

Quick fix build error when ptrdiff_t is not defined in types.h

or sys/types.h

Please do NEVER make this kind of quick hacks, but resolve it

properly, or

file a bugreport for it. This clutters up teh code way too much.

This breaks build. My patch fix build. Do you really want to keep CVS source unbuildable? I think nobody want. If you don't understand the reasoning of my patch, ask me ;)

Yasuo, as I explained to you in at least 2 emails last night/ early hours of this morning, the code in question came from fsock.c which was working on your system, and that it would have been better for you to find which headers on your system should have been added to network.c to make it compile. We are not against fixing the build, we just want to fix it properly. There was nothing stopping you from keeping your local quick fix in your own tree; committing it just means that the real problem will go unnoticed where it really matters. --Wez.