Re: cvs: php4 /main network.c
| From: | Jim Winstead | Date: | Sun, 17 Mar 2002 07:27:00 +0000 |
| Subject: | Re: cvs: php4 /main network.c | ||
| References: | 1 2 3 | Groups: | php.cvs |
| Request: | Send a blank email to php-cvs+get-10280@lists.php.net to get a copy of this message | ||
Yasuo Ohgaki <yasuo_ohgaki@yahoo.com> wrote:
> My fix is proper. Actually, the use of type that defined in stddef.h
> in PHP breaks compliance to ANSI C to my knowledge.
you are wrong. your fix was wrong.
in 4.1.2, ptrdiff_t was used in ext/standard/fsock.c
with wez's stream work, this usage got moved to main/network.c
wez just forgot to move the #include <stddef.h>
you might find a 'grep -ir ptrdiff_t .' and 'grep -ir stddef.h .'
on php trees going back to php 3.0.18 (and probably even earlier)
interesting.
WE HAVE BEEN USING ptrdiff_t AND stddef.h FOR A VERY, VERY LONG TIME.
please knock off this pointless ranting about ANSI compliance.
jim