Re: cvs: php4 /main network.c

derick@php.net wrote:

On Sat, 16 Mar 2002, Yasuo Ohgaki wrote: There is nothing wrong with a broken build for a few hours, this way the original developer can look into it and fix it properly.

My fix is proper. Actually, the use of type that defined in stddef.h in PHP breaks compliance to ANSI C to my knowledge. stddef.h is defined by X3J11 AFAIK. My reference is rather old, shoot me if newer ANSI C standard includes stddef.h. (Well most system has stddef.h now a days, but some opensource products defines their own ptrdiff_t. We may need to learn them.) If PHP aim to be compiled under any ANSI C compiler, we should change our rule or change this code. (or we should check if ANSI C standard says ptrdiff_t is defined in malloc.h)

If you don't understand the reasoning of my patch, ask me ;)

I understand, btu I don't agree.

Why not? You misunderstood my patch.

As I said this is quick hack to me. However, I'm also sure this is right.

Then you fix it on your local copy, and notify the oringial author of the code. Never do making quicks so 'it fixes it for me'. Beside I think it's quite rude to fiddle with others new and development code,

I'm not touching stream itself, but just fixing simple problem that does not matter much from techinical point of view. If I were Wez, I would like some other person fix these problem.

it doesn't fix the cause, but only the problem.

Now you see it applies to current code even with lastest one :) I have no problem with including stddef.h if it is inlucded properly and there is our own stddef.h for systems that does not have it. -- Yasuo Ohgaki