Re: cvs: php4 /ext/snmp snmp.c
| From: | Andi Gutmans | Date: | Sat, 11 May 2002 17:47:00 +0000 |
| Subject: | Re: cvs: php4 /ext/snmp snmp.c | ||
| References: | 1 2 | Groups: | php.cvs |
| Request: | Send a blank email to php-cvs+get-11839@lists.php.net to get a copy of this message | ||
At 20:09 11/05/2002 +0300, Zeev Suraski wrote:
At 20:04 11/05/2002, Rasmus Lerdorf wrote:I think it is. It's hard to see what has changed when people do lots of whitespace changes. AndiHey Sterling, if you are going to be maintaining this extension from now on, great, but otherwise, I see no point in minor style changes like this. if(gotroot==0) vs. if(!gotroot) ? Or a space here and there? That's not worth the added diff baggage that gets in the way when someone tries to track down real changes.I don't think diff baggage is important as readability...