Re: cvs: php4 /ext/snmp snmp.c
| From: | Andi Gutmans | Date: | Sat, 11 May 2002 18:25:10 +0000 |
| Subject: | Re: cvs: php4 /ext/snmp snmp.c | ||
| References: | 1 2 3 4 5 6 | Groups: | php.cvs |
| Request: | Send a blank email to php-cvs+get-11844@lists.php.net to get a copy of this message | ||
At 21:22 11/05/2002 +0300, Zeev Suraski wrote:
At 21:17 11/05/2002, Andi Gutmans wrote:Oh, I thought he also made functional changes. AndiAt 20:53 11/05/2002 +0300, Zeev Suraski wrote:That's exactly what Sterling did: --- Log: WS Fixes (and similair stylistic changes) --- Read the thread again...At 20:47 11/05/2002, Andi Gutmans wrote:The person should commit a whitespace patch and write in his comment "ws fix" and then commit his real fix. I don't see why we should change this rule. It has always existed.I think it is. It's hard to see what has changed when people do lots of whitespace changes.So do a whitespace-insensitive diff. Whitespace 'bugs' should be fixed whenever they're found.