Re: cvs: php4 /ext/snmp snmp.c
| From: | Sterling Hughes | Date: | Sat, 11 May 2002 17:49:38 +0000 |
| Subject: | Re: cvs: php4 /ext/snmp snmp.c | ||
| References: | 1 2 | Groups: | php.cvs |
| Request: | Send a blank email to php-cvs+get-11840@lists.php.net to get a copy of this message | ||
> Hey Sterling, if you are going to be maintaining this extension from now
> on, great, but otherwise, I see no point in minor style changes like this.
> if(gotroot==0) vs. if(!gotroot) ? Or a space here and there? That's not
> worth the added diff baggage that gets in the way when someone tries to
> track down real changes.
>
> -Rasmus
Well, I don't know if its real diff baggage, but rest assured, fixing the
whitespace was not my original intent, I was looking into a snmp bug (which
it turns out seems to be bogus), and made a few WS fixes on the way :)
-Sterling